Buggy Z2 material.

Post your suggestions for the site here so we can get on with ignoring them. Democracy in action!

Moderator: Zenith Nadir

User avatar
Zephyr
aaaa my capilaries
Posts: 129
Joined: Sat Jul 26, 2003 11:12 pm

Post by Zephyr »

Indeed, I tried making one and it didn't show up at all.

The comment box is still linked to the underdogs

We can probably change the affiliation links
User avatar
Commodore
fgsdfs
Posts: 2471
Joined: Wed Mar 12, 2003 5:44 pm
Location: :noitacoL
Contact:

Post by Commodore »

yeah, zeph's review appears and I'm like "It's fixed" then I cry when my review is kilt.
*POW* *CLANK* *PING*
User avatar
Zephyr
aaaa my capilaries
Posts: 129
Joined: Sat Jul 26, 2003 11:12 pm

Post by Zephyr »

Haha, if you look at the date of that review, it was made in August of last year. I have no idea why it suddenly showed up. The review I was speaking of previously wasn't that.
User avatar
Quantum P.
Level 17 Accordion Thief
Posts: 1433
Joined: Fri Sep 12, 2003 1:41 am
Location: Edmonds, WA
Contact:

Post by Quantum P. »

Reviews seem to be working fine now. But the question is, do they work for Commodore?
User avatar
Zephyr
aaaa my capilaries
Posts: 129
Joined: Sat Jul 26, 2003 11:12 pm

Post by Zephyr »

They still don't work for me... =(
User avatar
Quantum P.
Level 17 Accordion Thief
Posts: 1433
Joined: Fri Sep 12, 2003 1:41 am
Location: Edmonds, WA
Contact:

Post by Quantum P. »

I'm a bit baffled. Some info on exactly what you did and what happened would be appreciated.
User avatar
Zephyr
aaaa my capilaries
Posts: 129
Joined: Sat Jul 26, 2003 11:12 pm

Post by Zephyr »

I typed a review for a game, clicked submit and was taken to the page that says, "Your review has been submitted and can be seen here." When I clicked the link, it wasn't there.
User avatar
Zenith Nadir
this is my hammer
Posts: 2767
Joined: Wed Mar 12, 2003 11:40 am
Location: between the black and white spiders

Post by Zenith Nadir »

i have an odd feeling that the code for the review and comments scripts are still sending their updates to zzt.org, which no longer exists. i may be wrong though! i don't really know about these things
he looked upon the world and saw it was still depraved :fvkk:

Overall: Rotton egg for breakfast
User avatar
Quantum P.
Level 17 Accordion Thief
Posts: 1433
Joined: Fri Sep 12, 2003 1:41 am
Location: Edmonds, WA
Contact:

Post by Quantum P. »

I am able to make test comments without a problem. As for reviews, I figured out the problem: single quotes/apostrophes were not being escaped in the review text, which screwed up the SQL queries if your review contained this character. This was why the review script worked for me but nobody else; I was testing it using random letters (but no punctuation), while everybody else was posting real reviews (including characters such as apostrophes).

Anyway, reviews should be fixed now.
User avatar
Zephyr
aaaa my capilaries
Posts: 129
Joined: Sat Jul 26, 2003 11:12 pm

Post by Zephyr »

Yay! :safe:
User avatar
http://yahoo.com/
*shuggles*
Posts: 393
Joined: Mon Apr 26, 2004 5:11 am
Location: in madtom land

Post by http://yahoo.com/ »

So uh, how did that script ever work on the old site?
this is a deep and meaningful quote
User avatar
Zandor 12
What has science done???
Posts: 355
Joined: Wed Mar 12, 2003 5:19 am
Location: Neo Dakota
Contact:

Post by Zandor 12 »

Sorcery-assisted time travel.
User avatar
Quantum P.
Level 17 Accordion Thief
Posts: 1433
Joined: Fri Sep 12, 2003 1:41 am
Location: Edmonds, WA
Contact:

Post by Quantum P. »

http://yahoo.com/ wrote:So uh, how did that script ever work on the old site?
It's because of a little feature called Magic Quotes. Magic Quotes basically runs addslashes() automatically on all input received by the script; the idea is to escape certain characters (such as quotes) so that they don't mess up stuff like SQL queries. As far as I can tell, it was meant as a convenience; escaping important characters is one less thing you have to worry about.

However, I don't like it that much because it's a feature that can be turned on or off, depending on how PHP is configured. If your PHP script relies on Magic Quotes, moving it to a server on which that option is turned off will break it; the same goes for moving a script that expects raw input. This convenient feature actually makes PHP scripts less portable; to be portable, you must check to see if Magic Quotes is on before calling addslashes(), and this just seems like more hassle than it's worth.
User avatar
FSFunky
Fergalicious
Posts: 382
Joined: Wed Jan 14, 2004 11:52 am
Contact:

Post by FSFunky »

I preferred Zandor's explanation.
FUNKY DEFINITION: MAKE THEM BOYS GO LOCO
User avatar
Terryn
torpid refresh rates!
Posts: 45
Joined: Sun Jun 15, 2003 9:29 pm
Location: The Rainroom

Post by Terryn »

The download of "ZZT Crime" is broken (case-sensitivity issues. You link to "crimes.zip" when the file is "Crimes.zip".)
Post Reply