Page 3 of 5

Posted: Tue Apr 04, 2006 8:09 am
by Zephyr
Indeed, I tried making one and it didn't show up at all.

The comment box is still linked to the underdogs

We can probably change the affiliation links

Posted: Tue Apr 04, 2006 9:59 pm
by Commodore
yeah, zeph's review appears and I'm like "It's fixed" then I cry when my review is kilt.

Posted: Wed Apr 05, 2006 7:28 am
by Zephyr
Haha, if you look at the date of that review, it was made in August of last year. I have no idea why it suddenly showed up. The review I was speaking of previously wasn't that.

Posted: Thu Apr 06, 2006 4:58 am
by Quantum P.
Reviews seem to be working fine now. But the question is, do they work for Commodore?

Posted: Thu Apr 06, 2006 6:53 am
by Zephyr
They still don't work for me... =(

Posted: Thu Apr 06, 2006 7:48 am
by Quantum P.
I'm a bit baffled. Some info on exactly what you did and what happened would be appreciated.

Posted: Thu Apr 06, 2006 7:49 am
by Zephyr
I typed a review for a game, clicked submit and was taken to the page that says, "Your review has been submitted and can be seen here." When I clicked the link, it wasn't there.

Posted: Thu Apr 06, 2006 9:24 am
by Zenith Nadir
i have an odd feeling that the code for the review and comments scripts are still sending their updates to zzt.org, which no longer exists. i may be wrong though! i don't really know about these things

Posted: Thu Apr 06, 2006 11:47 pm
by Quantum P.
I am able to make test comments without a problem. As for reviews, I figured out the problem: single quotes/apostrophes were not being escaped in the review text, which screwed up the SQL queries if your review contained this character. This was why the review script worked for me but nobody else; I was testing it using random letters (but no punctuation), while everybody else was posting real reviews (including characters such as apostrophes).

Anyway, reviews should be fixed now.

Posted: Fri Apr 07, 2006 12:08 am
by Zephyr
Yay! :safe:

Posted: Fri Apr 07, 2006 2:41 am
by http://yahoo.com/
So uh, how did that script ever work on the old site?

Posted: Fri Apr 07, 2006 2:59 am
by Zandor 12
Sorcery-assisted time travel.

Posted: Fri Apr 07, 2006 9:19 am
by Quantum P.
http://yahoo.com/ wrote:So uh, how did that script ever work on the old site?
It's because of a little feature called Magic Quotes. Magic Quotes basically runs addslashes() automatically on all input received by the script; the idea is to escape certain characters (such as quotes) so that they don't mess up stuff like SQL queries. As far as I can tell, it was meant as a convenience; escaping important characters is one less thing you have to worry about.

However, I don't like it that much because it's a feature that can be turned on or off, depending on how PHP is configured. If your PHP script relies on Magic Quotes, moving it to a server on which that option is turned off will break it; the same goes for moving a script that expects raw input. This convenient feature actually makes PHP scripts less portable; to be portable, you must check to see if Magic Quotes is on before calling addslashes(), and this just seems like more hassle than it's worth.

Posted: Fri Apr 07, 2006 9:43 am
by FSFunky
I preferred Zandor's explanation.

Posted: Fri Apr 14, 2006 2:55 am
by Terryn
The download of "ZZT Crime" is broken (case-sensitivity issues. You link to "crimes.zip" when the file is "Crimes.zip".)